flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs
Date Wed, 26 Aug 2015 15:32:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14714165#comment-14714165
] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r37996420
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
---
    @@ -25,15 +25,21 @@
     import backtype.storm.generated.StormTopology;
     import backtype.storm.generated.SubmitOptions;
     import backtype.storm.generated.TopologyInfo;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
     import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
     import org.apache.flink.streaming.util.TestStreamEnvironment;
     
    +import java.util.HashMap;
     import java.util.Map;
     
     /**
      * {@link FlinkTestCluster} mimics a Storm {@link LocalCluster} for ITCases via a {@link
TestStreamEnvironment}.
      */
     public class FlinkTestCluster extends FlinkLocalCluster {
    +	// TODO remove and look up job
    --- End diff --
    
    This is also a larger issue in Storm compatibility (and not related to this PR). Need
to add helper method to `ClusterUtil` to get running jobs from `LocalFlinkMiniCluster` which
is used under the hood. I would rather have another JIRA for this than including it here.
Effects `FlinkLocalCluster`, too. 


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, Streaming, TaskManager,
Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is a "hard"
stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks such that the
sources can stop emitting data and shutdown cleanly, resulting in a clean shutdown of the
whole streaming job.
> This feature is a pre-requirment for https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message