flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...
Date Mon, 31 Aug 2015 13:45:27 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38312609
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
---
    @@ -45,9 +49,16 @@ public StormFileSpout(final String path) {
     	public void open(final Map conf, final TopologyContext context, final SpoutOutputCollector
collector) {
     		super.open(conf, context, collector);
     		try {
    +			/* if inputFile path has not set, get it from storm configuration  */
    +			if (this.path == null && conf != null && conf.containsKey(new String("textpath")))
{
    --- End diff --
    
    I would not check for `this.path == null`. If config is given, it should override constructor
path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message