flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HuangWHWHW <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...
Date Mon, 31 Aug 2015 03:53:58 GMT
Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1075#issuecomment-136245681
  
    @rmetzger  +1. I think add a test is helpful.
    Otherwise can you give us a infomation that prove the 'id = (counter << shifter)
+ taskId; ' will never generate the same id in different task?
    And a minor thing in you issue description:
    Is log2(8)=3 not 4?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message