flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Fri, 28 Aug 2015 12:30:28 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38194785
  
    --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendAddressConfigurationTest.java
---
    @@ -45,163 +43,122 @@
     
     	@Rule
     	public TemporaryFolder folder = new TemporaryFolder();
    -	
    +
     	@BeforeClass
     	public static void init() {
     		CliFrontendTestUtils.pipeSystemOutToNull();
     	}
    -	
    +
     	@Before
    -	public void clearConfig() {
    +	public void clearConfig() throws Exception {
     		CliFrontendTestUtils.clearGlobalConfiguration();
     	}
     
     	@Test
    -	public void testInvalidConfigAndNoOption() {
    +	public void testInvalidConfigAndNoOption() throws Exception {
    +		CliFrontend frontend = new CliFrontend(CliFrontendTestUtils.getInvalidConfigDir());
    +		CommandLineOptions options = mock(CommandLineOptions.class);
    +
     		try {
    -			CliFrontend frontend = new CliFrontend(CliFrontendTestUtils.getInvalidConfigDir());
    -			CommandLineOptions options = mock(CommandLineOptions.class);
    -
    -			try {
    -				frontend.getJobManagerAddress(options);
    -				fail("we expect an exception here because the we have no config");
    -			}
    -			catch (Exception e) {
    -				// expected
    -			}
    +			frontend.getJobManagerAddress(options);
    +			fail("we expect an exception here because the we have no config");
     		}
     		catch (Exception e) {
    -			e.printStackTrace();
    -			fail(e.getMessage());
    +			// expected
    --- End diff --
    
    Ah ok, this makes sense. Then I guess it's a problem of too unspecific exceptions which
we throw in our code. But this seems to be a general issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message