flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Fri, 28 Aug 2015 10:38:45 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38188430
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphConstructionTest.java
---
    @@ -450,8 +414,8 @@ private void verifyTestGraph(ExecutionGraph eg, JobID jobId,
     		}
     	}
     	
    -	@Test
    -	public void testCannotConnectMissingId() {
    +	@Test(expected = JobException.class)
    +	public void testCannotConnectMissingId() throws JobException {
    --- End diff --
    
    Do we have to add a `throws JobException` if you've specified a `@Test(expected = JobException.calss)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message