flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Fri, 28 Aug 2015 10:35:32 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38188243
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -411,6 +411,23 @@ class TaskManager(
                 log.debug(s"Cannot find task to fail for execution ${executionID})")
               }
     
    +        // stops a task
    +        case StopTask(executionID) =>
    +          val task = runningTasks.get(executionID)
    +          if (task != null) {
    +            try {
    +              task.stopExecution()
    +              sender ! new TaskOperationResult(executionID, true)
    +            } catch {
    +              case t: Throwable =>
    +                        sender ! new TaskOperationResult(executionID, false, t.getMessage())
    --- End diff --
    
    Why do we only send the message of the `Throwable` back? But be aware that we have to
check from where this `Throwable` comes. If it's not part of Flink (e.g. user code exception),
then we will have to serialize the exception to send it over the network (see #1048).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message