flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...
Date Wed, 26 Aug 2015 16:19:43 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1046#issuecomment-135085374
  
    Putting a nested "stormConf" into the configuration seems just wrong, sorry. Such a specific
hack in a generic utility cannot yield maintainable code.
    
    Why is that needed in the first place? Why not have a dedicated configuration object for
storm?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message