flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Wed, 26 Aug 2015 15:32:03 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r37996420
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
---
    @@ -25,15 +25,21 @@
     import backtype.storm.generated.StormTopology;
     import backtype.storm.generated.SubmitOptions;
     import backtype.storm.generated.TopologyInfo;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
     import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
     import org.apache.flink.streaming.util.TestStreamEnvironment;
     
    +import java.util.HashMap;
     import java.util.Map;
     
     /**
      * {@link FlinkTestCluster} mimics a Storm {@link LocalCluster} for ITCases via a {@link
TestStreamEnvironment}.
      */
     public class FlinkTestCluster extends FlinkLocalCluster {
    +	// TODO remove and look up job
    --- End diff --
    
    This is also a larger issue in Storm compatibility (and not related to this PR). Need
to add helper method to `ClusterUtil` to get running jobs from `LocalFlinkMiniCluster` which
is used under the hood. I would rather have another JIRA for this than including it here.
Effects `FlinkLocalCluster`, too. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message