flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sachingoel0101 <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...
Date Wed, 26 Aug 2015 14:36:32 GMT
Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/945#discussion_r37989214
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
    @@ -54,8 +54,12 @@
     	
     
     	/** Stores the concrete key/value pairs of this configuration object. */
    -	private final HashMap<String, Object> confData;
    -	
    +	private final Map<String, Object> confData;
    +
    +	/** Stores the program version */
    +	public final String FLINK_VERSION = getClass().getPackage().getImplementationVersion()
==
    +		null ? "FLINK_TEST_VERSION" : getClass().getPackage().getImplementationVersion();
    --- End diff --
    
    Ah yes. I had not considered this. In this case, the client version would be null.
    
    As for ensuring that compatible versions still work, you're right. This is why I'm not
in favor of using the current version string. A better approach would be to have specific
release versions in the configuration file, from where everything starts.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message