flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...
Date Wed, 26 Aug 2015 12:59:43 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
    @@ -547,7 +552,7 @@ class TaskManager(
             // successful registration. associate with the JobManager
             // we disambiguate duplicate or erroneous messages, to simplify debugging
    -        case AcknowledgeRegistration(_, leaderSessionID, jobManager, id, blobPort) =>
    +        case AcknowledgeRegistration(_, leaderSessionID, jobManager, id, blobPort, jobManagerID)
    --- End diff --
    This does not work because a `TaskManager's` registration can also be acknowledged by
an `AlreadyRegistered` message.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message