flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand
Date Tue, 25 Aug 2015 17:44:40 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1057#discussion_r37895597
  
    --- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
    @@ -127,7 +127,7 @@ FLINK_LIB_DIR=$FLINK_ROOT_DIR/lib
     # The above lib path is used by the shell script to retrieve jars in a 
     # directory, so it needs to be unmangled.
     FLINK_ROOT_DIR_MANGLED=`manglePath "$FLINK_ROOT_DIR"`
    -FLINK_CONF_DIR=$FLINK_ROOT_DIR_MANGLED/conf
    +if [ -z "$FLINK_CONF_DIR" ]; then FLINK_CONF_DIR=$FLINK_ROOT_DIR_MANGLED/conf; fi
    --- End diff --
    
    Yes, you don't need the else here because the variable is set either through the environment
or in the if block. Still, I'd prefer newlines but it is maybe just a matter of taste here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message