flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2569] [core] Add CsvReader support for ...
Date Tue, 25 Aug 2015 09:27:31 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfo.java
    @@ -174,13 +177,15 @@ public String toString() {
     			TypeInformation<?> info = BasicTypeInfo.getInfoFor(type);
     			if (info == null) {
    -				throw new IllegalArgumentException("Type at position " + i + " is not a basic type.");
    +				try {
    +					info = ValueTypeInfo.getValueTypeInfo((Class<Value>) type);
    --- End diff --
    Any class can implement the `Value` interface.
     We need to check if the class is on of the "BasicValue" classes, that Flink ships.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message