flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2556] Refactor/Fix pre-flight Key valid...
Date Mon, 24 Aug 2015 15:51:20 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/Keys.java ---
    @@ -209,6 +209,9 @@ public ExpressionKeys(int[] groupingFields, TypeInformation<T>
type, boolean all
     				throw new InvalidProgramException("Specifying keys via field positions is only valid
" +
     						"for tuple data types. Type: " + type);
    +			if (type.getArity() == 0) {
    +				throw new InvalidProgramException("Tuple size must be greater than 0. Size: " + type.getArity());
    --- End diff --
    this check was added specifically for Tuple0, as in the current code you'd get weird exceptions
when grouping on a Tuple0.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message