flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sachingoel0101 <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2458][FLINK-2449]Access distributed cac...
Date Sun, 16 Aug 2015 09:15:40 GMT
Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/970#discussion_r37143936
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -897,7 +897,7 @@ class TaskManager(
             config.timeout,
             libCache,
             fileCache,
    -        runtimeInfo)
    +        new TaskRuntimeInfo(hostname, taskManagerConfig, tdd.getAttemptNumber))
    --- End diff --
    
    This is to provide access to Task attempt number from Runtime Context. I should add a
description of the other tickets this resolves.
    Is this a good idea though? To fix five issues in one PR? Or should I open a separate
one and keep this one for just distributed cache?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message