flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Date Fri, 14 Aug 2015 15:26:25 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1004#issuecomment-131148744
  
    Wow, looks like a good piece of work. Nicely with tests and everything.
    Build also passes, style looks good.
    
    +1 to merge this from my side. I'd like to wait for a day or two to get a comment from
one of the Gelly people (Vasia or Andra).
    
    One thing, though: In the Batch and streaming APIs, we added a "completeness check" to
make sure that methods added to the Java APIs are also present in the Scala APIs. Would that
be a good thing to add here as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message