flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...
Date Thu, 13 Aug 2015 09:23:56 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/992#discussion_r36955316
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
---
    @@ -85,11 +84,12 @@ public void streamFromSocket(SourceContext<String> ctx, Socket
socket) throws Ex
     					}
     				}
     
    -				if (data == -1) {
    +				if (data == null) {
     					socket.close();
     					long retry = 0;
     					boolean success = false;
    -					while (retry < maxRetry && !success) {
    +					while ((retry < maxRetry || (retryForever && !isExit)) && !success)
{
    +						isRetrying = true;
    --- End diff --
    
    This flag is only necessary for your test and thus should be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message