flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HuangWHWHW <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2495][fix]Add a null point check in API...
Date Fri, 07 Aug 2015 12:57:51 GMT
Github user HuangWHWHW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/999#discussion_r36515671
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
---
    @@ -256,9 +256,11 @@ public ExecutionConfig getExecutionConfig() {
     		DataStream<OUT> returnStream = this.copy();
     
     		for (DataStream<OUT> stream : streams) {
    -			for (DataStream<OUT> ds : stream.unionedStreams) {
    -				validateUnion(ds.getId());
    -				returnStream.unionedStreams.add(ds.copy());
    +			if (stream != null) {
    --- End diff --
    
    Hi,
    you may look at this problem with my test above.
    As you see, if I ignore the null, code "temp2.union(temp1)" will just copy a new DataStream.
    And this new DataStream has absolutely no change comparing with temp2.
    So, If the temp2 is good, the new DataStream is good too.
    And the test or other case similar to this test will execute successfully.
    Instead, there just will be a error.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message