flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2495][fix]Add a null point check in API...
Date Fri, 07 Aug 2015 10:53:24 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
    @@ -256,9 +256,11 @@ public ExecutionConfig getExecutionConfig() {
     		DataStream<OUT> returnStream = this.copy();
     		for (DataStream<OUT> stream : streams) {
    -			for (DataStream<OUT> ds : stream.unionedStreams) {
    -				validateUnion(ds.getId());
    -				returnStream.unionedStreams.add(ds.copy());
    +			if (stream != null) {
    --- End diff --
    I'm not sure if it is good practice to ignore `null` referenced streams. Why not let it
fail here? We might hide other errors by skipping the problematic stream here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message