flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HuangWHWHW <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2477][Add]Add tests for SocketClientSin...
Date Thu, 06 Aug 2015 01:23:28 GMT
Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/977#issuecomment-128200510
  
    Hi,
    don`t worry and have a nice vacation!
    I`ll fix on the Class documentation and the static ports.
    As for the tests, I was considering the case coverage.
    Everyone could use SocketSinkFunction for invoke and without invoke as the function is
public.
    And I would like to combine tests to one test if you think the case coverage is not necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message