flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2457] Integrate Tuple0
Date Tue, 04 Aug 2015 13:54:20 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
    @@ -391,6 +392,10 @@ protected TypeExtractor() {
     				curT = typeToClass(curT).getGenericSuperclass();
    +			if(typeToClass(curT).equals(Tuple0.class)) {
    --- End diff --
    `curT` could be `TypeVariable` or someting else at this point. I think it's better to
use `if (curT instanceof Class<?> && curT == Tuple0.class)`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message