Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD7B11812E for ; Thu, 23 Jul 2015 10:14:20 +0000 (UTC) Received: (qmail 28978 invoked by uid 500); 23 Jul 2015 10:14:04 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 28939 invoked by uid 500); 23 Jul 2015 10:14:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 28929 invoked by uid 99); 23 Jul 2015 10:14:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 10:14:04 +0000 Date: Thu, 23 Jul 2015 10:14:04 +0000 (UTC) From: "Ufuk Celebi (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2395) Check Scala catch blocks for Throwable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638603#comment-14638603 ] Ufuk Celebi commented on FLINK-2395: ------------------------------------ Interesting link. Thanks for sharing! > Check Scala catch blocks for Throwable > -------------------------------------- > > Key: FLINK-2395 > URL: https://issues.apache.org/jira/browse/FLINK-2395 > Project: Flink > Issue Type: Improvement > Reporter: Till Rohrmann > Priority: Minor > > As described in [1], it's not a good practice to catch {{Throwables}} in Scala catch blocks because Scala uses some special exceptions for the control flow. Therefore we should check whether we can restrict ourselves to only catching subtypes of {{Throwable}}, such as {{Exception}}, instead. > [1] https://www.sumologic.com/2014/05/05/why-you-should-never-catch-throwable-in-scala/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)