Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 22 Jul 2015 12:00:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12846630.1437502586000.255557.1437566405795@Atlassian.JIRA>
In-Reply-To: <JIRA.12846630.1437502586000@Atlassian.JIRA>
References: <JIRA.12846630.1437502586000@Atlassian.JIRA>
 <JIRA.12846630.1437502586642@arcas>
Subject: [jira] [Commented] (FLINK-2388) JobManager should try retrieving
 jobs from archive
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636774#comment-14636774 ] 

ASF GitHub Bot commented on FLINK-2388:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/930#discussion_r35204984
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
    @@ -687,61 +687,23 @@ class JobManager(
         message match {
     
           case RequestAccumulatorResults(jobID) =>
    -        try {
    --- End diff --
    
    You're right, this should stay in there.


> JobManager should try retrieving jobs from archive
> --------------------------------------------------
>
>                 Key: FLINK-2388
>                 URL: https://issues.apache.org/jira/browse/FLINK-2388
>             Project: Flink
>          Issue Type: Task
>          Components: JobManager
>            Reporter: Enrique Bautista Barahona
>
> I was following the quickstart guide with the WordCount example and, when I entered the "analyze" page for the job, nothing came up. Apparently the JobManagerInfoServlet fails with a NullPointerException.
> I've been reading the code and I've seen the problem is in the processing of the RequestAccumulatorResultsStringified message in JobManager. There's a TODO where the accumulators should be retrieved from the archive.
> As I wanted to know more about Flink internals, I decided to try and fix it. I've later seen that there's currently ongoing work in that part of the code, so I guess maybe it's not needed, but if you want I could submit a PR. If you have already taken it into account and will solve it shortly, please feel free to close the issue.
> If you want to take a look, the commit is here: https://github.com/ebautistabar/flink/commit/8536352b21fb6c78ad8840b0397509df04358c6b


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)