Return-Path: 
 <issues-return-20263-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 47A861815D
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Thu,  2 Jul 2015 14:18:05 +0000 (UTC)
Received: (qmail 30827 invoked by uid 500); 2 Jul 2015 14:18:05 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 30788 invoked by uid 500); 2 Jul 2015 14:18:05 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 30774 invoked by uid 99); 2 Jul 2015 14:18:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2015 14:18:05 +0000
Date: Thu, 2 Jul 2015 14:18:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12842231.1435821781000.85133.1435846685104@Atlassian.JIRA>
In-Reply-To: <JIRA.12842231.1435821781000@Atlassian.JIRA>
References: <JIRA.12842231.1435821781000@Atlassian.JIRA>
 <JIRA.12842231.1435821781859@arcas>
Subject: [jira] [Commented] (FLINK-2311) Set flink-* dependencies in
 flink-contrib as "provided"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612003#comment-14612003 ] 

ASF GitHub Bot commented on FLINK-2311:
---------------------------------------

Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/880#issuecomment-118047809
  
    I see. But changing the scope to "provided" is the wrong way to go. You need to exclude unnecessary sub-module dependencies:
    ```
    <dependency>
      <groupId>org.apache.flink</groupId>
      <artifactId>flink-contrib</artifactId>
      <version>${project.version}</version>
      <exclusions>
        <exclusion>
          <groupId>flink-storm-compatiblitly-parent</groupId>
          <version>${project.version}</version>
        </exclusion>
        <exclusion>
          <groupId>flink-streaming-contrib</groupId>
          <version>${project.version}</version>
        </exclusion>
        <exclusion>
          <groupId>flink-tweet-inputformat</groupId>
          <version>${project.version}</version>
        </exclusion>
      </exclusions>
    </dependency>
    ```
    However, I am wondering if the statistics collection code is placed correctly into flink-contrib. I thought flink-contrib is a "parent" project only containing sub-modules. For this case, statistic collection would be an own sub-module and you could just include this sub-module into your dependencies (this resolves the problem naturally)


> Set flink-* dependencies in flink-contrib as "provided"
> -------------------------------------------------------
>
>                 Key: FLINK-2311
>                 URL: https://issues.apache.org/jira/browse/FLINK-2311
>             Project: Flink
>          Issue Type: Improvement
>          Components: flink-contrib
>    Affects Versions: 0.10, 0.9.1
>            Reporter: Alexander Alexandrov
>            Assignee: Alexander Alexandrov
>            Priority: Minor
>              Labels: easyfix, maven, patch
>             Fix For: 0.10, 0.9.1
>
>
> The {{flink-contrib}} folder is assumed to be provided by the user. As such, other {{flink-*}} dependencies referenced within {{flink-contrib}} should be set as _'provided'_ in order to keep the size of the user jars down. I'm currently testing a patch that changes the poms as suggested and will open a PR on GitHub if this everything passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)