Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 848DC18A67 for ; Wed, 29 Jul 2015 14:07:08 +0000 (UTC) Received: (qmail 64312 invoked by uid 500); 29 Jul 2015 14:07:08 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 64277 invoked by uid 500); 29 Jul 2015 14:07:08 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 64268 invoked by uid 99); 29 Jul 2015 14:07:08 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 14:07:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F3CBA19363D for ; Wed, 29 Jul 2015 14:07:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.971 X-Spam-Level: X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SSd6yy0zGRBL for ; Wed, 29 Jul 2015 14:07:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 7F2F5210DF for ; Wed, 29 Jul 2015 14:07:01 +0000 (UTC) Received: (qmail 62644 invoked by uid 99); 29 Jul 2015 14:07:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 14:07:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 433A2DFB3B; Wed, 29 Jul 2015 14:07:01 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: Cascading changes for compatibility Content-Type: text/plain Message-Id: <20150729140701.433A2DFB3B@git1-us-west.apache.org> Date: Wed, 29 Jul 2015 14:07:01 +0000 (UTC) Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/950#issuecomment-125962637 For robustness, can you restore the thread context classloader to the original one in a finally clause? Otherwise +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---