flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Gevay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection
Date Thu, 30 Jul 2015 16:44:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647915#comment-14647915
] 

Gabor Gevay commented on FLINK-2437:
------------------------------------

I just realized that it is not a problem that analyzePojo lets abstract classes through, so
the "return null" is not missing, sorry.

> TypeExtractor.analyzePojo has some problems around the default constructor detection
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-2437
>                 URL: https://issues.apache.org/jira/browse/FLINK-2437
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>            Reporter: Gabor Gevay
>            Assignee: Gabor Gevay
>            Priority: Minor
>
> If a class does have a default constructor, but the user forgot to make it public, then
TypeExtractor.analyzePojo still thinks everything is OK, so it creates a PojoTypeInfo. Then
PojoSerializer.createInstance blows up.
> Furthermore, a "return null" seems to be missing from the then case of the if after catching
the NoSuchMethodException which would also cause a headache for PojoSerializer.
> An additional minor issue is that the word "class" is printed twice in several places,
because class.toString also prepends it to the class name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message