flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maximilian Michels (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2388) JobManager should try retrieving jobs from archive
Date Wed, 22 Jul 2015 08:55:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636531#comment-14636531
] 

Maximilian Michels commented on FLINK-2388:
-------------------------------------------

Hi [~ebautistabar], thanks for finding and even looking into the problem. It's wrong to return
a null value if the accumulators are not found. Instead, we should send a {{AccumulatorNotFound}}
message. Then, the {{JobManagerInfoServlet}} doesn't have to deal with null values. I've prepared
a fix in the pull request.

I will add another commit to the pull request that forwards the message to the {{MemoryArchivist}}
that in turn replies to the {{JobManagerInfoServlet}}. 

> JobManager should try retrieving jobs from archive
> --------------------------------------------------
>
>                 Key: FLINK-2388
>                 URL: https://issues.apache.org/jira/browse/FLINK-2388
>             Project: Flink
>          Issue Type: Task
>          Components: JobManager
>            Reporter: Enrique Bautista Barahona
>
> I was following the quickstart guide with the WordCount example and, when I entered the
"analyze" page for the job, nothing came up. Apparently the JobManagerInfoServlet fails with
a NullPointerException.
> I've been reading the code and I've seen the problem is in the processing of the RequestAccumulatorResultsStringified
message in JobManager. There's a TODO where the accumulators should be retrieved from the
archive.
> As I wanted to know more about Flink internals, I decided to try and fix it. I've later
seen that there's currently ongoing work in that part of the code, so I guess maybe it's not
needed, but if you want I could submit a PR. If you have already taken it into account and
will solve it shortly, please feel free to close the issue.
> If you want to take a look, the commit is here: https://github.com/ebautistabar/flink/commit/8536352b21fb6c78ad8840b0397509df04358c6b



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message