flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2311) Set flink-* dependencies in flink-contrib as "provided"
Date Thu, 02 Jul 2015 14:18:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612003#comment-14612003
] 

ASF GitHub Bot commented on FLINK-2311:
---------------------------------------

Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/880#issuecomment-118047809
  
    I see. But changing the scope to "provided" is the wrong way to go. You need to exclude
unnecessary sub-module dependencies:
    ```
    <dependency>
      <groupId>org.apache.flink</groupId>
      <artifactId>flink-contrib</artifactId>
      <version>${project.version}</version>
      <exclusions>
        <exclusion>
          <groupId>flink-storm-compatiblitly-parent</groupId>
          <version>${project.version}</version>
        </exclusion>
        <exclusion>
          <groupId>flink-streaming-contrib</groupId>
          <version>${project.version}</version>
        </exclusion>
        <exclusion>
          <groupId>flink-tweet-inputformat</groupId>
          <version>${project.version}</version>
        </exclusion>
      </exclusions>
    </dependency>
    ```
    However, I am wondering if the statistics collection code is placed correctly into flink-contrib.
I thought flink-contrib is a "parent" project only containing sub-modules. For this case,
statistic collection would be an own sub-module and you could just include this sub-module
into your dependencies (this resolves the problem naturally)


> Set flink-* dependencies in flink-contrib as "provided"
> -------------------------------------------------------
>
>                 Key: FLINK-2311
>                 URL: https://issues.apache.org/jira/browse/FLINK-2311
>             Project: Flink
>          Issue Type: Improvement
>          Components: flink-contrib
>    Affects Versions: 0.10, 0.9.1
>            Reporter: Alexander Alexandrov
>            Assignee: Alexander Alexandrov
>            Priority: Minor
>              Labels: easyfix, maven, patch
>             Fix For: 0.10, 0.9.1
>
>
> The {{flink-contrib}} folder is assumed to be provided by the user. As such, other {{flink-*}}
dependencies referenced within {{flink-contrib}} should be set as _'provided'_ in order to
keep the size of the user jars down. I'm currently testing a patch that changes the poms as
suggested and will open a PR on GitHub if this everything passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message