flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2292) Report accumulators periodically while job is running
Date Fri, 10 Jul 2015 08:18:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621962#comment-14621962
] 

ASF GitHub Bot commented on FLINK-2292:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/896#discussion_r34335330
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/RuntimeEnvironment.java
---
    @@ -212,19 +218,19 @@ public InputGate getInputGate(int index) {
     		return inputGates;
     	}
     
    -	@Override
    -	public void reportAccumulators(Map<String, Accumulator<?, ?>> accumulators)
{
    -		AccumulatorEvent evt;
    -		try {
    -			evt = new AccumulatorEvent(getJobID(), accumulators);
    -		}
    -		catch (IOException e) {
    -			throw new RuntimeException("Cannot serialize accumulators to send them to JobManager",
e);
    -		}
    -
    -		ReportAccumulatorResult accResult = new ReportAccumulatorResult(jobId, executionId,
evt);
    -		jobManagerActor.tell(accResult, ActorRef.noSender());
    -	}
    +//	@Override
    --- End diff --
    
    Yes.


> Report accumulators periodically while job is running
> -----------------------------------------------------
>
>                 Key: FLINK-2292
>                 URL: https://issues.apache.org/jira/browse/FLINK-2292
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, TaskManager
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 0.10
>
>
> Accumulators should be sent periodically, as part of the heartbeat that sends metrics.
This allows them to be updated in real time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message