flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2166) Add fromCsvFile() to TableEnvironment
Date Fri, 31 Jul 2015 01:28:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648598#comment-14648598
] 

ASF GitHub Bot commented on FLINK-2166:
---------------------------------------

Github user jamescao commented on the pull request:

    https://github.com/apache/flink/pull/939#issuecomment-126536010
  
    Hi Chiwan
    
    Thanks for your comment! I was new to this community and I am not very familiar with the
design conventions.
    1. I was a little bit confused about the api structure. `TableEnvironment` is in `org.apache.flink.api.java.table`
so I guess it should be a java only api. In that case, the scala test I uploaded is inappropriate
in the first place.  If we introduce `fromCsvFile` for scala table api, it should be in `org.apace.flink.api.scala.table.TableEnviroment`.
Is this right? 
    2. I will work on a  scala api using `readCsvFile()` instead of delegating to the java
api.
    3. I will improve the test by comparing the result in memory.
    4. I will make the options comply to the builder pattern.
    
    Thanks!


> Add fromCsvFile() to TableEnvironment
> -------------------------------------
>
>                 Key: FLINK-2166
>                 URL: https://issues.apache.org/jira/browse/FLINK-2166
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>    Affects Versions: 0.9
>            Reporter: Fabian Hueske
>            Priority: Minor
>              Labels: starter
>
> Add a {{fromCsvFile()}} method to the {{TableEnvironment}} to read a {{Table}} from a
CSV file.
> The implementation should reuse Flink's CsvInputFormat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message