flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2105) Implement Sort-Merge Outer Join algorithm
Date Wed, 15 Jul 2015 13:17:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628035#comment-14628035
] 

ASF GitHub Bot commented on FLINK-2105:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/907#issuecomment-121611605
  
    Hi @jkovacs and @r-pogalz,
    thanks for this PR!
    
    It takes a while to review the changes because you are refactoring parts of the existing
code (which is good IMO). Started reviewing the PR but I'm not done yet. I checked the restructuring
of the existing MergeJoinIterators and everything is looking good so far. Nice work!
    I'll have a look at the new code (MergeOuterJoinIterators) in the next days.


> Implement Sort-Merge Outer Join algorithm
> -----------------------------------------
>
>                 Key: FLINK-2105
>                 URL: https://issues.apache.org/jira/browse/FLINK-2105
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Local Runtime
>            Reporter: Fabian Hueske
>            Assignee: Ricky Pogalz
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Flink does not natively support outer joins at the moment. 
> This issue proposes to implement a sort-merge outer join algorithm that can cover left,
right, and full outer joins.
> The implementation can be based on the regular sort-merge join iterator ({{ReusingMergeMatchIterator}}
and {{NonReusingMergeMatchIterator}}, see also {{MatchDriver}} class)
> The Reusing and NonReusing variants differ in whether object instances are reused or
new objects are created. I would start with the NonReusing variant which is safer from a user's
point of view and should also be easier to implement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message