flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1520) Read edges and vertices from CSV files
Date Mon, 20 Jul 2015 21:56:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634142#comment-14634142
] 

ASF GitHub Bot commented on FLINK-1520:
---------------------------------------

Github user shghatge commented on the pull request:

    https://github.com/apache/flink/pull/847#issuecomment-123057981
  
    The only problem with assuming NullValue if a value is missing is that we can't return
NullValue in place of VV.
    I mean to say Graph<K, VV, EV> in this VV or EV can't be NullValue. otherwise that
was what I was originally going for. 
    Maybe since any of the other methods to create DataSet/Graph don't provide a method to
give EdgeValue as NullValue and just expect the user to map it (at least that is what I saw),
maybe we could just remove the functionality. I had only added it since many examples seemed
to use it so I thought it would be nice to have that functionality. 
    In any case we can just keep one typesNullEdge method too because if they don't want that,
they can use normal overloaded types, 3 arguments for no NullValue, 2 arguments for null vertex
and 1 argument for null vertex and edge and just one method named typesNullEdge to tell that
only edges have NullValue.


> Read edges and vertices from CSV files
> --------------------------------------
>
>                 Key: FLINK-1520
>                 URL: https://issues.apache.org/jira/browse/FLINK-1520
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Shivani Ghatge
>            Priority: Minor
>              Labels: easyfix, newbie
>
> Add methods to create Vertex and Edge Datasets directly from CSV file inputs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message