flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chiwanpark <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2200] Add Flink with Scala 2.11 in Mave...
Date Mon, 27 Jul 2015 17:00:02 GMT
Github user chiwanpark commented on the pull request:

    There is wrong description in building documentation. Because Scala 2.11 profile activation
is determined by property "scala-2.11", Scala 2.10 profile is activated when we execute `mvn
-Pscala-2.11`. Following commands is right:
    mvn clean install -DskipTests -Dscala-2.11
    About the shading artifacts, your guess is right. Because Hadoop packages don't need Scala
dependencies, I didn't add suffix to them. But if we need the suffix for them to maintain
uniformity, we can add the suffix. How do you think?
    I just found another problem. I opened the dependency reduced pom in my maven repository,
there are some property expressions in artifact id. For example, the following is head of
flink-runtime module's pom.xml:
    <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    As you see, there are property expressions (${scala.suffix}) in artifactId. I think that
it can be a problem. How can I solve this?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message