flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...
Date Wed, 22 Jul 2015 09:06:19 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/930#discussion_r35193782
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -707,33 +706,33 @@ class JobManager(
     
           case RequestAccumulatorResultsStringified(jobId) =>
             try {
    -          val accumulatorValues: Array[StringifiedAccumulatorResult] = {
    -            currentJobs.get(jobId) match {
    -              case Some((graph, jobInfo)) =>
    -                val accumulators = graph.aggregateUserAccumulators()
    -
    -                val result: Array[StringifiedAccumulatorResult] = new
    -                    Array[StringifiedAccumulatorResult](accumulators.size)
    -
    -                var i = 0
    -                accumulators foreach {
    -                  case (name, accumulator) =>
    -                    val (typeString, valueString) =
    -                      if (accumulator != null) {
    -                        (accumulator.getClass.getSimpleName, accumulator.toString)
    -                      } else {
    -                        (null, null)
    -                      }
    -                    result(i) = new StringifiedAccumulatorResult(name, typeString, valueString)
    -                    i += 1
    -                }
    -                result
    -              case None =>
    -                null // TODO check also archive
    -            }
    +          currentJobs.get(jobId) match {
    +            case Some((graph, jobInfo)) =>
    +              val accumulators = graph.aggregateUserAccumulators()
    +
    +              val result: Array[StringifiedAccumulatorResult] = new
    +                  Array[StringifiedAccumulatorResult](accumulators.size)
    +
    +              var i = 0
    +              accumulators foreach {
    +                case (name, accumulator) =>
    +                  val (typeString, valueString) =
    +                    if (accumulator != null) {
    +                      (accumulator.getClass.getSimpleName, accumulator.toString)
    +                    } else {
    +                      (null, null)
    +                    }
    +                  result(i) = new StringifiedAccumulatorResult(name, typeString, valueString)
    +                  i += 1
    +              }
    +
    +              sender() ! AccumulatorResultStringsFound(jobId, result)
    +
    +            case None =>
    +              // TODO check also archive
    +              sender() ! AccumulatorResultsNotFound(jobId)
    --- End diff --
    
    Same here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message