flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2359] [java api] Add factory methods to...
Date Wed, 15 Jul 2015 14:27:14 GMT
Github user ggevay commented on the pull request:

    I included the reformatting changes because the generator is making them. This is happening
because some modifications were made directly to some generated codes in the past, which made
them inconsistent with the generator. But I guess the goal should be that the generator program
would have no effect on the master. One way to achieve this is to commit the changes the generator
makes, and the other way would be to change the generator to follow the reformatting. Do you
think that I should change the PR to the latter with respect to the reformattings as well?
(I already did the latter with respect to some real changes, see my opening comment.)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message