flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Date Tue, 14 Jul 2015 22:16:22 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/905#discussion_r34626753
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java ---
    @@ -618,9 +620,9 @@ public long count() throws Exception {
     	}
     	
     	/**
    -	 * Returns a distinct set of a {@link Tuple} {@link DataSet} using all fields of the
tuple.
    +	 * Returns a distinct set of a {@link DataSet} using all fields of the tuple.
     	 * <p>
    -	 * Note: This operator can only be applied to Tuple DataSets.
    +	 * If the input is a {@link Tuple} {@link DataSet}, uses all fields of the tuple.
    --- End diff --
    
    Can you change this to "If the input is a composite type (Tuple or Pojo type), distinct
is performed on all fields and each field must be a key type."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message