flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...
Date Mon, 13 Jul 2015 19:50:06 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/896#discussion_r34503586
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
    @@ -53,32 +53,34 @@
     
     	private final ExecutionConfig executionConfig;
     
    -	private final HashMap<String, Accumulator<?, ?>> accumulators = new HashMap<String,
Accumulator<?, ?>>();
    -	
    +	private final Map<String, Accumulator<?, ?>> accumulators;
    +
     	private final DistributedCache distributedCache;
    -	
    -	
    +
    +
     	public AbstractRuntimeUDFContext(String name,
    --- End diff --
    
    I think a common practice is to have optional arguments last, e.g. the cpTasks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message