flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...
Date Thu, 09 Jul 2015 16:31:47 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -172,13 +173,20 @@
     	/** The library cache, from which the task can request its required JAR files */
     	private final LibraryCacheManager libraryCache;
     	/** The cache for user-defined files that the invokable requires */
     	private final FileCache fileCache;
     	/** The gateway to the network stack, which handles inputs and produced results */
     	private final NetworkEnvironment network;
    +	/** The registry of this task which enables live reporting of accumulators */
    +	private final AccumulatorRegistry accumulatorRegistry;
    --- End diff --
    Since the AccumulatorRegistry is only used task-internally, and always retrieved form
there, it should be initialized internally. Saves one more constructor parameter and helps
with separation of concerns.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message