flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [wip] [FLINK-2288] [FLINK-2302] Setup ZooKeepe...
Date Tue, 07 Jul 2015 13:27:30 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/886#discussion_r34038403
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -993,9 +1000,34 @@ object JobManager {
           configuration.setString(ConfigConstants.FLINK_BASE_DIR_PATH_KEY, configDir + "/..")
         }
     
    -    val hostname = configuration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
null)
    -    val port = configuration.getInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY,
    -      ConfigConstants.DEFAULT_JOB_MANAGER_IPC_PORT)
    +    // HA mode
    +    val (hostname, port) = if (ZooKeeperUtil.isJobManagerHighAvailabilityEnabled(configuration))
{
    +      // TODO @removeme @tillrohrmann This is the place where the host and random port
for JM is
    +      // chosen.  For the FlinkMiniCluster you have to choose it on your own.
    +      LOG.info("HA mode.")
    --- End diff --
    
    How about we make this a bit more prominent ;-) "Staring JobManager in High Availability
Mode".
    
    The other case should also have a log message, for example "Starting JobManager without
High Availability".
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message