flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2297] [ml] Add threshold setting for SV...
Date Wed, 01 Jul 2015 09:18:11 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/874#discussion_r33661424
  
    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/pipeline/Predictor.scala
---
    @@ -121,7 +121,7 @@ object Predictor {
     
             input.mapWithBcVariable(model){
               (element, model) => {
    -            (element, predictOperation.predict(element, model))
    +            (element, predictOperation.predict(element, model, resultingParameters))
    --- End diff --
    
    Hmm I'm not so sure either what is the best way to go here. My initial idea was to isolate
the predict operation as much as possible from the code necessary to do the setup. I don't
like the `ParameterMap` much, because it allows you to have access to much more information
than necessary. IMO it's better to extract the information once at one place and then have
an explicit representation of the information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message