flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thvasilo <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2297] [ml] Add threshold setting for SV...
Date Wed, 01 Jul 2015 09:17:54 GMT
Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/874#discussion_r33661400
  
    --- Diff: docs/libs/ml/svm.md ---
    @@ -186,5 +199,5 @@ svm.fit(trainingDS)
     val testingDS: DataSet[Vector] = env.readVectorFile(pathToTestingFile)
     
     // Calculate the predictions for the testing data set
    -val predictionDS: DataSet[LabeledVector] = svm.predict(testingDS)
    +val predictionDS: DataSet[(FlinkVector, Double)] = svm.predict(testingDS)
    --- End diff --
    
    I prefer FlinkVector in the library code at least to make sure we differentiate from Scala
and Breeze. But you are right, for the example this import should suffice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message