Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: aljoscha <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-831-flink@git.apache.org>
In-Reply-To: <git-pr-831-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2203] handling null values for
 RowSeria...
Content-Type: text/plain
Message-Id: <20150613145820.9FA7ADFF16@git1-us-west.apache.org>
Date: Sat, 13 Jun 2015 14:58:20 +0000 (UTC)

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/831#discussion_r32371124
  
    --- Diff: flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala ---
    @@ -102,20 +119,39 @@ class RowSerializer(fieldSerializers: Array[TypeSerializer[Any]])
         val len = fieldSerializers.length
     
         val result = new Row(len)
    -    var i = 0
    -    while (i < len) {
    -      result.setField(i, fieldSerializers(i).deserialize(source))
    -      i += 1
    +
    +    var index = 0
    +    while (index < len) {
    +      val isNull: Boolean = source.readBoolean()
    +      if (isNull) {
    +        result.setField(index, null)
    +      } else {
    +        val serializer: TypeSerializer[Any] = fieldSerializers(index)
    +        result.setField(index, serializer.deserialize(source))
    +      }
    +      index += 1
         }
         result
       }
     
    +  private final val booleanSerializer = new BooleanSerializer()
    +
       override def copy(source: DataInputView, target: DataOutputView): Unit = {
         val len = fieldSerializers.length
         var i = 0
         while (i < len) {
    +      booleanSerializer.copy(source, target)
    --- End diff --
    
    I think it would be easier to do
    ```
    target.writeBoolean(source.readBoolean())
    ```
    here, instead of going through the extra abstraction of the BooleanSerializer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---