Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: uce <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-811-flink@git.apache.org>
In-Reply-To: <git-pr-811-flink@git.apache.org>
Subject: [GitHub] flink pull request: [scripts] cleanup release script and
 make it m...
Content-Type: text/plain
Message-Id: <20150610085057.627D6DFBC8@git1-us-west.apache.org>
Date: Wed, 10 Jun 2015 08:50:57 +0000 (UTC)

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/811#discussion_r32098664
  
    --- Diff: tools/create_release_files.sh ---
    @@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
       exit 1
     fi
     
    +##
    +## Variables with defaults (if not overwritten by environment)
    +##
     GPG_PASSPHRASE=${GPG_PASSPHRASE:-XXX}
     GPG_KEY=${GPG_KEY:-XXX}
    +GIT_AUTHOR=${GIT_AUTHOR:-"Your name <you@apache.org>"}
     GIT_BRANCH=${GIT_BRANCH:-branch-1.0}
     OLD_VERSION=${OLD_VERSION:-0.6-incubating-SNAPSHOT}
     RELEASE_VERSION=${NEW_VERSION}
     RELEASE_CANDIDATE=${RELEASE_CANDIDATE:-rc1}
     NEW_VERSION_HADOOP1=${NEW_VERSION_HADOOP1:-"$RELEASE_VERSION-hadoop1"}
    -USER_NAME=${USER_NAME:-pwendell}
    +USER_NAME=${USER_NAME:-yourapacheidhere}
     MVN=${MVN:-mvn}
     GPG=${GPG:-gpg}
    -SHASUM=${SHASUM:-sha512sum}
    -MD5SUM=${MD5SUM:-md5sum}
    -sonatype_user=${sonatype_user:-rmetzger} #legacy variable name referring to maven
    +sonatype_user=${sonatype_user:-yourapacheidhere}
     sonatype_pw=${sonatype_pw:-XXX}
     
    -#echo $NEW_VERSION_HADOOP1
    -#sleep 5
    -#set -e
     
    -# create source package
    +if [ "$(uname)" == "Darwin" ]; then
    +    SHASUM=shasum
    +    MD5SUM=md5
    --- End diff --
    
    I didn't know that md5sum correctly works with the reversed files as well. So this is optional.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---