Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2905118C7A for ; Thu, 4 Jun 2015 09:40:05 +0000 (UTC) Received: (qmail 65908 invoked by uid 500); 4 Jun 2015 09:40:05 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 65863 invoked by uid 500); 4 Jun 2015 09:40:05 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 65850 invoked by uid 99); 4 Jun 2015 09:40:04 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2015 09:40:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 886B01A44C8 for ; Thu, 4 Jun 2015 09:40:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.971 X-Spam-Level: X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id NF6OtP1V8Anq for ; Thu, 4 Jun 2015 09:40:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 53A8E2054B for ; Thu, 4 Jun 2015 09:39:59 +0000 (UTC) Received: (qmail 65725 invoked by uid 99); 4 Jun 2015 09:39:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2015 09:39:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7C061E0FC2; Thu, 4 Jun 2015 09:39:58 +0000 (UTC) From: fhueske To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-1319][core] Add static code analysis fo... Content-Type: text/plain Message-Id: <20150604093958.7C061E0FC2@git1-us-west.apache.org> Date: Thu, 4 Jun 2015 09:39:58 +0000 (UTC) Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/729#discussion_r31706246 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SingleInputUdfOperator.java --- @@ -54,8 +54,11 @@ private Map> broadcastVariables; + // NOTE: only set this variable via setSemanticProperties() --- End diff -- Just a quick question (haven't checked the code). Does the analyzer also respect semantic information provided via the Operator API (withForwardedFields()), i.e., not via function annotations? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---