flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Metzger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2294) Keyed State does not work with DOP=1
Date Tue, 30 Jun 2015 12:53:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608236#comment-14608236

Robert Metzger commented on FLINK-2294:

It would have been nice if you waited until you reached agreement with Aljoscha on the implementation,
instead of just committing it to master, without a pull request.

>From my understanding, I agree with Guyla, that it is easier to set the nextInput outside
the operator, instead of inside all operators.

> Keyed State does not work with DOP=1
> ------------------------------------
>                 Key: FLINK-2294
>                 URL: https://issues.apache.org/jira/browse/FLINK-2294
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Aljoscha Krettek
>            Assignee: Gyula Fora
>            Priority: Blocker
> When changing the DOP from 3 to 1 in StatefulOperatorTest.apiTest() the test fails. The
reason seems to be that the element is not properly set when chaining is happening.
> Also, requiring this:
> {code}
> headContext.setNextInput(nextRecord);
> streamOperator.processElement(nextRecord);
> {code}
> to be called seems rather fragile. Why not set the element in {{processElement()}}. This
would also make for cleaner encapsulation, since now all outside code must assume that operators
have a {{StreamingRuntimeContext}} on which they set the next element.
> The state/keyed state machinery seems dangerously undertested.

This message was sent by Atlassian JIRA

View raw message