flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gyula Fora (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2284) Confusing/inconsistent PartitioningStrategy
Date Mon, 29 Jun 2015 09:05:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605314#comment-14605314
] 

Gyula Fora commented on FLINK-2284:
-----------------------------------

But I think it is completely okay to modify them to make it consistent with the batch.

> Confusing/inconsistent PartitioningStrategy
> -------------------------------------------
>
>                 Key: FLINK-2284
>                 URL: https://issues.apache.org/jira/browse/FLINK-2284
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Stephan Ewen
>
> The PartitioningStrategy in {{org.apache.flink.streaming.runtime.partitioner.StreamPartitioner.java}}
is non standard and not easily understandable.
> What form of partitioning is `SHUFFLE`? Shuffle just means "redistribute", it says nothing
about what it does. Same with `DISTRIBUTE`. Also `GLOBAL` is not a well-defined/established
term. Why is `GROUPBY` a partition type? Doesn't grouping simply hash partition (like I assume
"SHUFFLE" means), so why does it have an extra entry?
> Sticking with principled and established names/concepts is important to allow people
to collaborate on the code. 
> Why not stick with the partitioning types defined in the batch API? They are well defined
and named:
> ```
> NONE, FORWARD, RANDOM, HASH, RANGE, FORCED_REBALANCE, BROADCAST, CUSTOM
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message