flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2182) Add stateful Streaming Sequence Source
Date Mon, 08 Jun 2015 13:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577152#comment-14577152
] 

ASF GitHub Bot commented on FLINK-2182:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/804#discussion_r31911662
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
    @@ -412,7 +412,7 @@ public void registerType(Class<?> type) {
     		if (from > to) {
     			throw new IllegalArgumentException("Start of sequence must not be greater than the
end");
     		}
    -		return fromCollection(new NumberSequenceIterator(from, to), BasicTypeInfo.LONG_TYPE_INFO,
"Sequence Source");
    +		return addSource(new StatefulSequenceSource(from, to), "Sequence Source").setParallelism(1);
     	}
    --- End diff --
    
    But why wouldn't we allow the user to explicitly set a higher parallelism. The call is
quite explicit and I think I would be more surprised as a user if my source did not run in
parallel even though I set a higher parallelism. 


> Add stateful Streaming Sequence Source
> --------------------------------------
>
>                 Key: FLINK-2182
>                 URL: https://issues.apache.org/jira/browse/FLINK-2182
>             Project: Flink
>          Issue Type: Improvement
>          Components: eaming, Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message