flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2165) Rename Table conversion methods in TableEnvironment
Date Fri, 05 Jun 2015 11:05:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574317#comment-14574317
] 

ASF GitHub Bot commented on FLINK-2165:
---------------------------------------

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/793#issuecomment-109258889
  
    +1 This is not API-breaking since we didn't have a release with the Table API yet.


> Rename Table conversion methods in TableEnvironment
> ---------------------------------------------------
>
>                 Key: FLINK-2165
>                 URL: https://issues.apache.org/jira/browse/FLINK-2165
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 0.9
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>             Fix For: 0.9
>
>
> The {{TableEnvironment}} provides methods to convert DataSets and DataStreams into Tables
and back. These methods are called {{toTable()}}, {{toSet()}}, and {{toStream()}}.
> I propose to rename the methods into {{fromDataSet()}}, {{fromDataStream()}}, {{toDataSet()}},
and {{toDataStream()}} for the following reasons:
> - {{fromDataSet()}}, {{fromDataStream()}} is closer to the SQL FROM expression
> - It allows to add methods such as {{fromCSV()}}, {{fromHCat()}}, {{fromParquet()}},
and so on to the {{TableEnvironment}}
> - {{toSet()}} and {{toStream()}} should be renamed for consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message