flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
Date Thu, 04 Jun 2015 07:05:38 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572290#comment-14572290
] 

ASF GitHub Bot commented on FLINK-2155:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/775#issuecomment-108758033
  
    +1 change looks good.
    Can you squash your changes into one commit, named 
    `[FLINK-2155] Enforce import restriction on usage of Flink shaded package and Commons
Validate`
    That makes merging for us easier.


> Add an additional checkstyle validation for illegal imports
> -----------------------------------------------------------
>
>                 Key: FLINK-2155
>                 URL: https://issues.apache.org/jira/browse/FLINK-2155
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Lokesh Rajaram
>            Assignee: Lokesh Rajaram
>
> Add an additional check-style validation for illegal imports.
> To begin with the following two package import are marked as illegal:
>      1. org.apache.commons.lang3.Validate
>      2. org.apache.flink.shaded.*
> Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message