flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2136) Test the streaming scala API
Date Thu, 04 Jun 2015 13:37:40 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572761#comment-14572761
] 

ASF GitHub Bot commented on FLINK-2136:
---------------------------------------

Github user gaborhermann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/771#discussion_r31719989
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
---
    @@ -617,7 +617,7 @@ protected ExecutionConfig getExecutionConfig() {
     	 */
     	public <R> SingleOutputStreamOperator<R, ?> fold(R initialValue, FoldFunction<OUT,
R> folder) {
     		TypeInformation<R> outType = TypeExtractor.getFoldReturnTypes(clean(folder),
getType(),
    -				Utils.getCallLocationName(), false);
    +				Utils.getCallLocationName(), true);
    --- End diff --
    
    I set allowMissing to true as it was set at flatMap. Leaving it on false caused the call
fold in the Scala DataStream fail.


> Test the streaming scala API
> ----------------------------
>
>                 Key: FLINK-2136
>                 URL: https://issues.apache.org/jira/browse/FLINK-2136
>             Project: Flink
>          Issue Type: Test
>          Components: Scala API, Streaming
>    Affects Versions: 0.9
>            Reporter: Márton Balassi
>            Assignee: Gábor Hermann
>
> There are no test covering the streaming scala API. I would suggest to test whether the
StreamGraph created by a certain operation looks as expected. Deeper layers and runtime should
not be tested here, that is done in streaming-core.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message