flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1993) Replace MultipleLinearRegression's custom SGD with optimization framework's SGD
Date Wed, 03 Jun 2015 15:08:38 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570973#comment-14570973
] 

ASF GitHub Bot commented on FLINK-1993:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/760#discussion_r31632977
  
    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
---
    @@ -87,11 +89,11 @@ import org.apache.flink.ml.pipeline.{FitOperation, PredictOperation,
Predictor}
       *
       */
     class MultipleLinearRegression extends Predictor[MultipleLinearRegression] {
    -
    +  import org.apache.flink.ml._
    --- End diff --
    
    Good catch :-)


> Replace MultipleLinearRegression's custom SGD with optimization framework's SGD
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-1993
>                 URL: https://issues.apache.org/jira/browse/FLINK-1993
>             Project: Flink
>          Issue Type: Task
>          Components: Machine Learning Library
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: ML
>             Fix For: 0.9
>
>
> The current implementation of MultipleLinearRegression uses a custom SGD implementation.
Flink's optimization framework also contains a SGD optimizer which should replace the custom
implementation once the framework is merged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message